HTML API: Only stop on full matches for requested tag name. #7189
Conversation
An optimization pass on the HTML API left a bug in the `matches()` method, whereby it would falsely detect a tag name match if the found tag were a lexical subset of the requested tag. This occurred because of the use of `substr_compare()` without checking that the outer lengths matched. This patch resolves the bug by adding the length check. Follow-up to [58613]. Props dmsnell, westonruter. See #61545.
Trac Ticket MissingThis pull request is missing a link to a Trac ticket. For a contribution to be considered, there must be a corresponding ticket in Trac. To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description. More information about contributing to WordPress on GitHub can be found in the Core Handbook. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
I've confirmed that the tests fail without the fix but pass with it. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
| public function test_next_tag_should_not_match_on_substrings_of_a_requested_tag() { | ||
| $processor = new WP_HTML_Tag_Processor( '<p><pic><picture>' ); | ||
|
|
||
| $this->assertTrue( | ||
| $processor->next_tag( 'PICTURE' ), | ||
| 'Failed to find a tag when requested: check test setup.' | ||
| ); | ||
|
|
||
| $this->assertSame( | ||
| 'PICTURE', | ||
| $processor->get_tag(), | ||
| 'Should have skipped past substring tag matches, directly finding the PICTURE element.' | ||
| ); | ||
| } |
There was a problem hiding this comment.
In the case we had, this would have failed:
$processor = new WP_HTML_Tag_Processor( '<p><img></p>' );
$this->assertFalse(
$processor->next_tag( 'PICTURE' ),
'Unexpectedly found a tag when requested: check test setup.'
);Maybe good to have a negative case added to this as well.
There was a problem hiding this comment.
@westonruter I think these are the same case. in both cases they stop at the P - am I missing something?
There was a problem hiding this comment.
nevermind - I didn't understand your comment at first.
There was a problem hiding this comment.
added the test, but I used a different failure message
Co-authored-by: Weston Ruter <westonruter@git.wordpress.org>
An optimization pass on the HTML API left a bug in the `matches()` method, whereby it would falsely detect a tag name match if the found tag were a lexical subset of the requested tag. This occurred because of the use of `substr_compare()` without checking that the outer lengths matched. This patch resolves the bug by adding the length check. Developed in #7189 Discussed in https://core.trac.wordpress.org/ticket/61545 Follow-up to [58613]. Props dmsnell, westonruter. See #61545. git-svn-id: https://develop.svn.wordpress.org/trunk@58893 602fd350-edb4-49c9-b593-d223f7449a82
An optimization pass on the HTML API left a bug in the `matches()` method, whereby it would falsely detect a tag name match if the found tag were a lexical subset of the requested tag. This occurred because of the use of `substr_compare()` without checking that the outer lengths matched. This patch resolves the bug by adding the length check. Developed in WordPress/wordpress-develop#7189 Discussed in https://core.trac.wordpress.org/ticket/61545 Follow-up to [58613]. Props dmsnell, westonruter. See #61545. Built from https://develop.svn.wordpress.org/trunk@58893 git-svn-id: http://core.svn.wordpress.org/trunk@58289 1a063a9b-81f0-0310-95a4-ce76da25c4cd
An optimization pass on the HTML API left a bug in the `matches()` method, whereby it would falsely detect a tag name match if the found tag were a lexical subset of the requested tag. This occurred because of the use of `substr_compare()` without checking that the outer lengths matched. This patch resolves the bug by adding the length check. Developed in WordPress/wordpress-develop#7189 Discussed in https://core.trac.wordpress.org/ticket/61545 Follow-up to [58613]. Props dmsnell, westonruter. See #61545. Built from https://develop.svn.wordpress.org/trunk@58893 git-svn-id: https://core.svn.wordpress.org/trunk@58289 1a063a9b-81f0-0310-95a4-ce76da25c4cd
An optimization pass on the HTML API left a bug in the `matches()` method, whereby it would falsely detect a tag name match if the found tag were a lexical subset of the requested tag. This occurred because of the use of `substr_compare()` without checking that the outer lengths matched. This patch resolves the bug by adding the length check. Developed in WordPress#7189 Discussed in https://core.trac.wordpress.org/ticket/61545 Follow-up to [58613]. Props dmsnell, westonruter. See #61545. git-svn-id: https://develop.svn.wordpress.org/trunk@58893 602fd350-edb4-49c9-b593-d223f7449a82
Trac ticket: Core-61545.
An optimization pass on the HTML API left a bug in the
matches()method, whereby it would falsely detect a tag name match if the
found tag were a lexical subset of the requested tag. This occurred
because of the use of
substr_compare()without checking that theouter lengths matched.
This patch resolves the bug by adding the length check.
Follow-up to [58613] (#6890).
Props @dmsnell, @westonruter.
See Core-61545.