-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HTML API: Add new is_self_contained() method to Tag Processor. #7198
base: trunk
Are you sure you want to change the base?
Conversation
This new method will help calling code trying to determine whether or not to expect to find a closing tag, since the Tag Processor consumes the entire element (including the closing tag) when it encounters one.
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN:
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Trac Ticket MissingThis pull request is missing a link to a Trac ticket. For a contribution to be considered, there must be a corresponding ticket in Trac. To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description. More information about contributing to WordPress on GitHub can be found in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This function seems helpful, part of the reason I believe that is that is seems to roughly to some of the special conditions here in the HTML Processor:
wordpress-develop/src/wp-includes/html-api/class-wp-html-processor.php
Lines 795 to 806 in 06f7c82
return ! ( | |
// Comments, text nodes, and other atomic tokens. | |
'#' === $token_name[0] || | |
// Doctype declarations. | |
'html' === $token_name || | |
// Void elements. | |
self::is_void( $token_name ) || | |
// Special atomic elements. | |
( 'html' === $token_namespace && in_array( $token_name, array( 'IFRAME', 'NOEMBED', 'NOFRAMES', 'SCRIPT', 'STYLE', 'TEXTAREA', 'TITLE', 'XMP' ), true ) ) || | |
// Self-closing elements in foreign content. | |
( 'html' !== $token_namespace && $token_has_self_closing ) | |
); |
Do you think we can and should adapt this method to support our use case there?
@sirreal this is seeming more complicated than I want it to be. specifically the interaction with |
This new method will help calling code trying to determine whether or not to expect to find a closing tag, since the Tag Processor consumes the entire element (including the closing tag) when it encounters one.