Update packages for 6.7 Beta 1 (1/3) #7226
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Trac Ticket MissingThis pull request is missing a link to a Trac ticket. For a contribution to be considered, there must be a corresponding ticket in Trac. To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description. More information about contributing to WordPress on GitHub can be found in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
I cherry-picked the listed fix and published a new version of WP packages to npm so we could proceed further with this PR:
|
|
@gziolo Thanks for helping out with that, I've pushed a further update to the packages. I've gone through the php changes folder in the Gutenberg repo and found three PRs that need to be merged in to WP-Dev and added them to the todo list. One of them is a draft PR from Isabel that will need to be taken over while she is on extended leave. |
peterwilsoncc
force-pushed
the
try/package-update
branch
from
93f7516
to
b9830c7
Compare
peterwilsoncc
force-pushed
the
try/package-update
branch
from
d4ce80c
to
173e785
Compare
| $show_label = empty( $attributes['showLabel'] ) ? ' screen-reader-text' : ''; | ||
| $default_label = __( 'Categories' ); | ||
| $label_text = ! empty( $attributes['label'] ) ? $attributes['label'] : $default_label; | ||
| $wrapper_markup = '<div %1$s><label class="wp-block-categories__label' . $show_label . '" for="' . esc_attr( $id ) . '">' . $label_text . '</label>%2$s</div>'; |
There was a problem hiding this comment.
Escaping label text
There was a problem hiding this comment.
Lines of code updated in WordPress/gutenberg#65272, but introduced earlier.
There was a problem hiding this comment.
Introduced in WordPress/gutenberg#56364, so during this release cycle.
| $formatted_date = get_the_modified_date( empty( $attributes['format'] ) ? '' : $attributes['format'], $post_ID ); | ||
| if ( isset( $attributes['format'] ) && 'human-diff' === $attributes['format'] ) { | ||
| // translators: %s: human-readable time difference. | ||
| $formatted_date = sprintf( __( '%s ago' ), human_time_diff( get_post_timestamp( $post_ID, 'modified' ) ) ); |
There was a problem hiding this comment.
May need the same logic as above for future dates in case plugin authors are doing interesting things with published posts.
peterwilsoncc
force-pushed
the
try/package-update
branch
from
173e785
to
be78d45
Compare
noisysocks
changed the title
--latest tag.wp-6.7 tag
There was a problem hiding this comment.
I smoke tested all four editors and couldn't see any glaring issues aside from https://core.trac.wordpress.org/ticket/61960#comment:16.
Obviously I can't test everything so I'll do a call out for developers to check that their recent features have landed as expected.
Onwards! 👍🌈
|
Committed in r59072. |
noisysocks
changed the title
wp-6.7 tag
Trac ticket: Core-61906
Currently known issues
Merge Add support for positioning child blocks inside a Grid block. #6910N/A: Behind experimental flag.canUpdateBlockBindingseditor setting #7258This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.