HTML API: Fix a bug where the namespace was forced to 'html' #7232
Conversation
When the HTML Processor had no current_element, it was defaulting to 'html'. Instead, the `parent::get_namespace()` should be used. This seems to happen when advancing to a real token, for example, when the HTML Processor handles HTML like this: ```html <svg>text ``` The HTML processor calls `get_modifiable_text()` internally when the text node is reached. At this time, there is no current_element and the namespace was defaulting, incorrectly, to `html`.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
When the HTML Processor had no current_element, it was defaulting to
'html'. Instead, the
parent::get_namespace()should be used.This seems to happen when advancing to a real token, for example, when
the HTML Processor handles HTML like this:
The HTML processor calls
get_modifiable_text()internally when thetext node is reached. At this time, there is no current_element and the
namespace was defaulting, incorrectly, to
html.I discovered this while working on #7230.
Trac ticket: https://core.trac.wordpress.org/ticket/61576
Follow up to: [58868]
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.