-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HTML API: Add missing NOBR end tag handling #7282
HTML API: Add missing NOBR end tag handling #7282
Conversation
Trac Ticket MissingThis pull request is missing a link to a Trac ticket. For a contribution to be considered, there must be a corresponding ticket in Trac. To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description. More information about contributing to WordPress on GitHub can be found in the Core Handbook. |
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN:
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
@dmsnell Have a look at this please, it seems to be an unintentional omission to me. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great catch. Thankfully this is for the deprecated NOBR
element, so its impact should have been minimal. I don't think it warrants any new tickets or notes, as it's a minor bug fix. Thank you!
When the HTML Processor was introduced, an oversight led to a missing case for handling a closing `NOBR` tag. The `NOBR` element is a deprecated tag and should not be used. This patch adds the missing case so that the deprecated `NOBR` end tag is appropriately handled. Developed in #7282 Discussed in https://core.trac.wordpress.org/ticket/61576 Follow-up to [56274]. Props jonsurrell. See #61576. git-svn-id: https://develop.svn.wordpress.org/trunk@58967 602fd350-edb4-49c9-b593-d223f7449a82
When the HTML Processor was introduced, an oversight led to a missing case for handling a closing `NOBR` tag. The `NOBR` element is a deprecated tag and should not be used. This patch adds the missing case so that the deprecated `NOBR` end tag is appropriately handled. Developed in WordPress/wordpress-develop#7282 Discussed in https://core.trac.wordpress.org/ticket/61576 Follow-up to [56274]. Props jonsurrell. See #61576. Built from https://develop.svn.wordpress.org/trunk@58967 git-svn-id: https://core.svn.wordpress.org/trunk@58363 1a063a9b-81f0-0310-95a4-ce76da25c4cd
When the HTML Processor was introduced, an oversight led to a missing case for handling a closing `NOBR` tag. The `NOBR` element is a deprecated tag and should not be used. This patch adds the missing case so that the deprecated `NOBR` end tag is appropriately handled. Developed in WordPress/wordpress-develop#7282 Discussed in https://core.trac.wordpress.org/ticket/61576 Follow-up to [56274]. Props jonsurrell. See #61576. Built from https://develop.svn.wordpress.org/trunk@58967 git-svn-id: http://core.svn.wordpress.org/trunk@58363 1a063a9b-81f0-0310-95a4-ce76da25c4cd
When the HTML Processor was introduced, an oversight led to a missing case for handling a closing `NOBR` tag. The `NOBR` element is a deprecated tag and should not be used. This patch adds the missing case so that the deprecated `NOBR` end tag is appropriately handled. Developed in WordPress#7282 Discussed in https://core.trac.wordpress.org/ticket/61576 Follow-up to [56274]. Props jonsurrell. See #61576. git-svn-id: https://develop.svn.wordpress.org/trunk@58967 602fd350-edb4-49c9-b593-d223f7449a82
The
NOBR
end tag handling seems to have been omitted for this part of the HTML standard:This does not seem to be intentional. Introduced in [56274].
Trac ticket:
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.