-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Interactivity Router: Update for latest package changes #7447
Interactivity Router: Update for latest package changes #7447
Conversation
…hould be deprecated instead." This reverts commit bbec266.
Keep the original method (as a no-op) to avoid possible fatal errors.
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN:
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Here's the diff comparing this with the original commit from ad1fabe / [59097]: diff --git before/src/wp-includes/interactivity-api/class-wp-interactivity-api.php after/src/wp-includes/interactivity-api/class-wp-interactivity-api.php
index e4dec8e262..8ffd612b13 100644
--- before/src/wp-includes/interactivity-api/class-wp-interactivity-api.php
+++ after/src/wp-includes/interactivity-api/class-wp-interactivity-api.php
@@ -993,6 +993,16 @@ final class WP_Interactivity_API {
CSS;
}
+ /**
+ * Deprecated.
+ *
+ * @since 6.5.0
+ * @deprecated 6.7.0 Use {@see WP_Interactivity_API::print_router_markup} instead.
+ */
+ public function print_router_loading_and_screen_reader_markup() {
+ _deprecated_function( __METHOD__, '6.7.0', 'WP_Interactivity_API::print_router_markup' );
+ }
+
/**
* Outputs markup for the @wordpress/interactivity-router script module.
* |
@michalczaplinski This is ready to try again 🙂 |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
…uter_loading_and_screen_reader_markup` method
|
||
// Call the new method. | ||
$this->print_router_markup(); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe we need to call the "new" method here. I've just added it in e09839e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Committed with https://core.trac.wordpress.org/changeset/59130 |
Reapply changes from [59097] / #7304.
Restore and deprecated the renamed method
print_router_loading_and_screen_reader_markup
.Description and testing instructions are the same as on the original PR:
Trac ticket: https://core.trac.wordpress.org/ticket/60647
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.