Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme JSON: replace top-level background style objects on merge #7697

Conversation

ramonjd
Copy link
Member

@ramonjd ramonjd commented Nov 1, 2024

A PR that syncs the Gutenberg PR:

This PR fixes an omission in the theme json merge logic where top-level background image objects are not replaced, rather they are merged. Blocks are already catered for via ::get_block_nodes().

To test, run npm run test:php -- --filter=Tests_Theme_wpThemeJson

Trac ticket: https://core.trac.wordpress.org/ticket/62328

…el background image objects are not replaced, rather they are merged. Blocks are already catered for via ::get_block_nodes().
@ramonjd ramonjd self-assigned this Nov 1, 2024
Copy link

github-actions bot commented Nov 1, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props ramonopoly.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link

github-actions bot commented Nov 1, 2024

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Copy link
Contributor

@andrewserong andrewserong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As in the Gutenberg PR (WordPress/gutenberg#66656), the logic looks good to me, and this is smoke testing well in theme.json and the site editor. I haven't run into any issues as a result of replacing rather than merging the backgroundImage property.

LGTM! 🚀

@ramonjd
Copy link
Member Author

ramonjd commented Nov 1, 2024

Committed in r59335 / b1b5761

@ramonjd ramonjd closed this Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants