Memory access out of bounds with WooCommerce development plugin

[samueljseay]

I had a look through the issues before raising this, I am aware it's quite similar to #1131 (comment)

I recently started implementing branch previews for WooCommerce with Playground and when WooCommerce loads I get request time out errors and memory out of bounds errors like:

Uncaught (in promise) Error: memory access out of bounds
    at #handleRequest (worker-thread-8ad48778.js?wpVersion=6.5&phpVersion=8.0&php-extension=iconv&php-extension=mbstring&p…:48:3538)
    at async WebPHP.run (worker-thread-8ad48778.js?wpVersion=6.5&phpVersion=8.0&php-extension=iconv&php-extension=mbstring&p…:37:15194)
    at async #u (worker-thread-8ad48778.js?wpVersion=6.5&phpVersion=8.0&php-extension=iconv&php-extension=mbstring&p…:54:2744)
    at async #l (worker-thread-8ad48778.js?wpVersion=6.5&phpVersion=8.0&php-extension=iconv&php-extension=mbstring&p…:54:2315)
    at async PlaygroundWorkerEndpoint.request (worker-thread-8ad48778.js?wpVersion=6.5&phpVersion=8.0&php-extension=iconv&php-extension=mbstring&p…:58:9271)

You can reproduce with this playground link:

https://playground.wordpress.net/#%7B%22landingPage%22:%22/wp-admin/admin.php?page=wc-admin%22,%22preferredVersions%22:%7B%22php%22:%228.0%22,%22wp%22:%22latest%22%7D,%22phpExtensionBundles%22:%5B%22kitchen-sink%22%5D,%22features%22:%7B%22networking%22:true%7D,%22steps%22:%5B%7B%22step%22:%22installPlugin%22,%22pluginZipFile%22:%7B%22resource%22:%22url%22,%22url%22:%22https://playground.wordpress.net/plugin-proxy.php?org=woocommerce&repo=woocommerce&workflow=Build%20Live%20Branch&artifact=plugins-8797272447&pr=46761%22%7D,%22options%22:%7B%22activate%22:true%7D%7D,%7B%22step%22:%22login%22,%22username%22:%22admin%22,%22password%22:%22password%22%7D%5D,%22plugins%22:%5B%5D%7D

Pinging @brandonpayton to take a look as requested by Adam.

Thanks all 🙇

[brandonpayton]

Hi @samueljseay, I am planning to take a look at this next.

[brandonpayton]

Actually, it sounds like we are going to wait a bit on #134 for now because JSPI should hopefully solve this class of issue.

[adamziel]

@brandonpayton is this the same issue, though? This one isn’t „unreachable statement” but „memory access out of bounds”. Let’s give it a try with JSPI and see if it’s still happening.

[brandonpayton]

@adamziel, that makes sense. I made a note to try this with your JSPI branch on Monday.

[brandonpayton]

The repro link is not currently working for me. I'm encountering the error:

GET https://playground.wordpress.net/plugin-proxy.php?org=woocommerce&repo=woocommerce&workflow=Build%20Live%20Branch&artifact=plugins-8797272447&pr=46761 400 (Invalid request)

I'm not yet sure if this is an issue with Playground, the website, or the repro URL and plan to look into it more tomorrow.

[brandonpayton]

The current artifact expiry in the above Woo PR is 7 days, and the original artifact is now expired. I re-ran the workflow to obtain a new artifact. The following link should work for the next week:

https://playground.wordpress.net/#%7B%22landingPage%22:%22/wp-admin/admin.php?page=wc-admin%22,%22preferredVersions%22:%7B%22php%22:%228.0%22,%22wp%22:%22latest%22%7D,%22phpExtensionBundles%22:%5B%22kitchen-sink%22%5D,%22features%22:%7B%22networking%22:true%7D,%22steps%22:%5B%7B%22step%22:%22installPlugin%22,%22pluginZipFile%22:%7B%22resource%22:%22url%22,%22url%22:%22https://playground.wordpress.net/plugin-proxy.php?org=woocommerce&repo=woocommerce&workflow=Build%20Live%20Branch&artifact=plugins-8797451193&pr=46761%22%7D,%22options%22:%7B%22activate%22:true%7D%7D,%7B%22step%22:%22login%22,%22username%22:%22admin%22,%22password%22:%22password%22%7D%5D,%22plugins%22:%5B%5D%7D