Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash when enabling network and adding a YouTube video to a post #1730

Closed
fluiddot opened this issue Sep 4, 2024 · 2 comments
Closed

Crash when enabling network and adding a YouTube video to a post #1730

fluiddot opened this issue Sep 4, 2024 · 2 comments

Comments

@fluiddot
Copy link
Contributor

fluiddot commented Sep 4, 2024

Saving a post with a YouTube block results in a crash if the Network access is enabled.

Steps to reproduce it:

  1. Enable Network access.
  2. Navigate to WP-Admin -> Posts.
  3. Add a new post.
  4. Add a YouTube block.
  5. Insert a YouTube URL.
  6. Click on Embed.
  7. Save the post.

Logs:

[04-Sept-2024 13:27:13 UTC] WASM Crash Fatal: 
"unreachable" WASM instruction executed.

The typical reason is a PHP function missing from the ASYNCIFY_ONLY
list when building PHP.wasm.

You will need to file a new issue in the WordPress Playground repository
and paste this error message there:

https://github.com/WordPress/wordpress-playground/issues/new

If you're a core developer, the typical fix is to:

* Isolate a minimal reproduction of the error
* Add a reproduction of the error to php-asyncify.spec.ts in the WordPress Playground repository
* Run 'npm run fix-asyncify'
* Commit the changes, push to the repo, release updated NPM packages

Below is a list of all the PHP functions found in the stack trace to
help with the minimal reproduction. If they're all already listed in
the Dockerfile, you'll need to trigger this error again with long stack
traces enabled. In node.js, you can do it using the --stack-trace-limit=100
CLI option: 

    * <unknown>
 Error: 
"unreachable" WASM instruction executed.

The typical reason is a PHP function missing from the ASYNCIFY_ONLY
list when building PHP.wasm.

You will need to file a new issue in the WordPress Playground repository
and paste this error message there:

https://github.com/WordPress/wordpress-playground/issues/new

If you're a core developer, the typical fix is to:

* Isolate a minimal reproduction of the error
* Add a reproduction of the error to php-asyncify.spec.ts in the WordPress Playground repository
* Run 'npm run fix-asyncify'
* Commit the changes, push to the repo, release updated NPM packages

Below is a list of all the PHP functions found in the stack trace to
help with the minimal reproduction. If they're all already listed in
the Dockerfile, you'll need to trigger this error again with long stack
traces enabled. In node.js, you can do it using the --stack-trace-limit=100
CLI option: 

    * <unknown>

    at #handleRequest (https://playground.wordpress.net/worker-thread-962e7bc6.js:53:5901)
    at async PHP.run (https://playground.wordpress.net/worker-thread-962e7bc6.js:53:1789)
    at async #d (https://playground.wordpress.net/worker-thread-962e7bc6.js:61:6175)
    at async #c (https://playground.wordpress.net/worker-thread-962e7bc6.js:61:5842)
    at async PlaygroundWorkerEndpoint.request (https://playground.wordpress.net/worker-thread-962e7bc6.js:4:8812)

URL:

https://playground.wordpress.net/?php=8.0&wp=latest&storage=none&networking=yes
@brandonpayton
Copy link
Member

Thanks for reporting this, @fluiddot! I believe this was addressed later by #1729.

Are we good to close this one?

@brandonpayton brandonpayton moved this from Inbox to Needs Author's Reply in Playground Board Sep 9, 2024
@fluiddot
Copy link
Contributor Author

Thanks for reporting this, @fluiddot! I believe this was addressed later by #1729.

Are we good to close this one?

Yep, I forgot to close this issue when #1729 got merged. Thanks for the call out 🙇 !

@github-project-automation github-project-automation bot moved this from Needs Author's Reply to Done in Playground Board Sep 10, 2024
@adamziel adamziel moved this from Done to Inbox in Playground Board Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

4 participants
@adamziel @brandonpayton @fluiddot and others