Add more asyncify-listed PHP functions to fix Studio crash #1729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonpayton
added
[Type] Bug
|
Note: The new PHP functions may be an incorrect list of functions to add. I was able to cause Playground CLI to crash when running on Node.js with a particular dataset, but it turns out the crash is different from the original error Studio folks have mentioned offline. So I'm waiting to see what that stacktrace is and plan to derive a different set of PHP function names from that. |
|
It turns out these crashes appear related, and it looks like these changes address the issue. Let's go ahead, merge this, and release updated npm packages. |
brandonpayton
deleted the
fix-studio-crash-with-more-asyncify-listed-php-functions
branch
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for the change, related issues, implementation details
This PR adds more PHP function names to our asyncify list to hopefully address a crash encountered by the Studio app.
Testing Instructions (or ideally a Blueprint)