Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Settings menu is visible after clicking "Restore from .zip" #1903

Open
ajotka opened this issue Oct 16, 2024 · 1 comment
Open

Settings menu is visible after clicking "Restore from .zip" #1903

ajotka opened this issue Oct 16, 2024 · 1 comment

Comments

@ajotka
Copy link
Contributor

ajotka commented Oct 16, 2024

Settings menu is visible after clicking "Restore from .zip"

Image
@bgrgicak bgrgicak moved this from Inbox to Up next in Playground Board Oct 16, 2024
@ajotka ajotka mentioned this issue Oct 16, 2024
Merged
@adamziel
Copy link
Collaborator

Good spot!

adamziel pushed a commit that referenced this issue Oct 25, 2024
@ajotka
[Website] Hide Settings menu after clicking "Restore from .zip (#1904)
00ae887 
## Motivation for the change, related issues

Issue #1903 

## Implementation details

Because Modal was in the same component as Dropdown Menu it was always
visible when Dropdown was open (and disappears when I tried to force
close menu item, because of unmounting).

So I decided to wrap dropdown with context and move there whole logic.


## Testing Instructions (or ideally a Blueprint)

Just open Playground and go to settigns.

## Screen with results


![image](https://github.com/user-attachments/assets/30f40e26-ed8b-4183-b2d2-682fb44c6f1e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Playground Board
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@adamziel @ajotka