Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create block theme: Google Fonts don't work #534

Closed
adamziel opened this issue Jun 8, 2023 · 1 comment
Closed

Create block theme: Google Fonts don't work #534

adamziel opened this issue Jun 8, 2023 · 1 comment

Comments

@adamziel
Copy link
Collaborator

adamziel commented Jun 8, 2023

As seen in #276, this won't work:

  1. Install Create Block Theme on a WordPress Playground instance (example)
  2. Go to Appearance -> Manage Theme Fonts -> Add Google font button
  3. Select a Google font from the dropdown menu
  4. Select a font variant from the list of fonts
  5. Click the 'Add Google fonts to your theme' button
  6. You should see the above error

Installing Google fonts involves network calls. Playground in the browser doesn't support that at the moment because of CORS and SSL problems – see #85. Can Google fonts feature be disabled for now?

cc @mikachan

@adamziel
Copy link
Collaborator Author

Solved by the fetch()-based network support added in #724

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant