-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Blueprints Builder getting stuck #863
Labels
Comments
adamziel
added
[Type] Bug
An existing feature does not function as intended
[Package][@wp-playground] Blueprints
labels
Dec 11, 2023
I question whether fixing this problem in Builder v1 when we need a new Builder v2 built from scratch. |
adamziel
added a commit
that referenced
this issue
Apr 19, 2024
Fixes the stuck Playground loading process on https://playground.wordpress.net/builder/builder.html Technically, we trash the existing iframe and start a new one instead of trying to bind multiple Playground clients to the same one. They very likely competed for events and missing even a single one meant not finishing the Playground loading sequence. This also fixes the following issues with the builder: * Cmd+s saving the Blueprint to the disk instead of running it * Too many double quotes inserted when completing a step name Furthermore, it adds an "Edit the Blueprint" link to the hamburger menu. Closes #863 ## Follow-up work Scrap the entire Builder codebase and rebuild it with CodeMirror and generic autocompletion (Ace doesn't work well for mobile, and the current autocompletion is bound to an exact JSON schema shape). ## Testing plan 1. Go to http://127.0.0.1:5400/website-server/builder/builder.html 1. Run a few Blueprints 1. Reload them 40 times 1. Confirm Playground loaded every single time
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Blueprints builder got merged in PR #773:
https://playground.wordpress.net/builder/builder.html
Unfortunately, it's affected by a blocking issue:
When re-running blueprints in the builder, sometimes the playground will simply stop progressing and never return success or failure.
We need to determine whether this is builder-specific, and the root cause of the issue.
The text was updated successfully, but these errors were encountered: