Wrong handling of arrays in HTTP POST requests

[TobiasBg]

While testing my plugin in the Playground, I found that either the "webserver part" or the "PHP part" seems to be treating HTTP POST variables wrong that are an array.

In particular, in my plugin I have an HTML form with inputs like

<input type="text" name="table[name]" value="" />

Note the array-type name attribute.

In PHP, this should be available as $_POST['table']['name']. However, $_POST['table'] does not exist.

A var_dump( $_POST ); gives

array(9) {
  ...
  ["table[name]"]=>
  string(4) "test"
  ["table[description]"]=>
  string(4) "test"
  ["table[rows]"]=>
  string(1) "5"
  ["table[columns]"]=>
  string(1) "5"
  ...
}

here (unneeded info stripped).

On a "normal" setup, I however (correctly) get

array(6) {
  ...
  ["table"]=>
  array(4) {
    ["name"]=>
    string(4) "test"
    ["description"]=>
    string(5) "test"
    ["rows"]=>
    string(1) "5"
    ["columns"]=>
    string(1) "5"
  }
  ...
}

[adamziel]

Great spot @TobiasBg - this should absolutely work as you outlined.

Noting that the bug resides in PHPServer#dispatchToPHP and an ideal fix would include a regression unit test similar to the ones PHP.ts has: https://github.com/WordPress/wordpress-playground/blob/trunk/src/php-wasm/__tests__/index.ts

@artemiomorales you might be interested in this issue

[adamziel]

Solved in 3359e60, thank you for reporting @TobiasBg!

[adamziel]

#107 introduced a full PHP SAPI that handles parsing data, populating $_GET, $_POST, $_FILES, $_SERVER, $_COOKIES etc. and populating the php://input stream