Fix mbregex support #1155
Merged
Fix mbregex support #1155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgrgicak
added
[Type] Bug
Collaborator
|
Aha, good work @bgrgicak! This might need a rebuild, unfortunately, as I merged another WASM PR before, but it looke great otherwise – thank you! 🎉 |
adamziel
approved these changes
Mar 29, 2024
bgrgicak
force-pushed
the
fix/815-mbregex-support
branch
from
37c39ba to
99e9173
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #815
What is this PR doing?
It fixes support for
mbregexand adds a test to ensure it keeps working.What problem is it solving?
Ensures support for
mbregex.How is the problem addressed?
By fixing a
ifcondition in the Docker file that prevented PHP > 7.0 from enablingmbregex.Also, the code wrongly assumed that PHP 7.4 includes
oniguruma, but it doesn't, so it's now added to PHP 7.4.Testing Instructions