Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make kitchen sink extension bundle the default #1191

Merged
merged 6 commits into from
Apr 3, 2024
Merged

Make kitchen sink extension bundle the default #1191

merged 6 commits into from
Apr 3, 2024

Commits on Apr 3, 2024

  1. Website: Default to the Kitchen Sink extension bundle 

    Many reported Playground issues are caused by using the "light" build
that ships without popular PHP extensions like finfo or DOMDocument.
This PR changes the default PHP build loaded on the website to "kitchen sink"
where all these extensions are shipped. This increases the bundle size
from ~6MB to ~12MB, but reduces the number of ways in which Playground
may fail.

 ## Testing instructions

* Confirm the E2E tests pass
* Navigate to /phpinfo.php and confirm libxml is enabled by default (it
  says --enable-xmlreader)
* Go to Playground settings and uncheck the "Load extensions" checkbox.
* Confirm that /phpinfo.php now says libxml is disabled
  (--disable-xmlreader)
    @adamziel
    adamziel committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    d0a0726 View commit details
    Browse the repository at this point in the history

  2. Website: Default to the kitchen sink extension bundle 

    Many reported issues are caused by Playground defaulting to the
"light" PHP build. It saves 6MB of initial downloads, but it confuses
new users with issues like [broken image editing](#1190).

This PR changes the PHP bundle loaded by default to the "kitchen sink"
one that ships with PHP extensions like finfo, GD, libxml.

 ## Testing instructions

* Confirm the e2e tests passed.
* Go to local Playground
* Visit "/phpinfo.php" in Playground, confirm libxml is enabled (the
  output should contain --enable-xmlreader)
* Open Playground configuration modal, uncheck the additional PHP
  extensions, confirm your choice
* Confirm phpinfo.php now reports libxmls is disabled
* Interact with that modal again, turn on the PHP extensions, confirm
  libxml is loaded again

CC @flexseth @dmsnell @bgrgicak @brandonpayton
    @adamziel
    adamziel committed Apr 3, 2024
    2 Configuration menu
    Copy the full SHA
    99ba52b View commit details
    Browse the repository at this point in the history

  3. Default to the kitchen sink bundle in startPlaygroundWeb when no Blue… 

    …print is specified
    @adamziel
    adamziel committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    112aac7 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'trunk' into make-kitchen-sink-extension-bundle-the-default

    @adamziel
    adamziel authored Apr 3, 2024
    Configuration menu
    Copy the full SHA
    f7babd5 View commit details
    Browse the repository at this point in the history

  5. Adjust E2E tests

    @adamziel
    adamziel committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    3aed26e View commit details
    Browse the repository at this point in the history

  6. Adjust e2e test

    @adamziel
    adamziel committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    034c5a9 View commit details
    Browse the repository at this point in the history