GitHub: Don't delete all the files when exporting a theme #1308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes themes and plugins export that got affected by #1174: * Uses the theme/plugin directory as the content root * Uses the adjusted `fromPlaygroundRoot` value instead of the one coming from the form. Closes #1296 ## Testing instructions * Import https://github.com/Automattic/themes/tree/trunk/foam from GitHub and export it immediately. There should be no files changed in the PR. * Confirm https://github.com/adamziel/playground-docs-workflow still works with this PR
adamziel
added
[Type] Bug
adamziel
commented
Apr 23, 2024
packages/playground/website/src/github/github-export-form/form.tsx
Outdated
Show resolved
Hide resolved
adamziel
commented
Apr 23, 2024
packages/playground/website/src/github/github-export-form/form.tsx
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes themes and plugins export that got affected by #1174:
fromPlaygroundRootvalue instead of the one coming from the form.Closes #1296
Testing instructions