Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .nvmrc and .npmrc #137

Merged
merged 3 commits into from
Feb 21, 2023
Merged

Conversation

danielbachhuber
Copy link
Member

Fixes #135

.nvmrc Outdated
@@ -0,0 +1 @@
v16.19.0
Copy link
Member

@gziolo gziolo Feb 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Node.js 18 is the active line at the moment. See https://nodejs.dev/en/about/releases/.

We had lts/* in Gutenberg for quite some time, if I recall correctly. I'm not sure if there is something similar for engines in package.json. Anyway, LTS still meets the requirement >=16.0.0.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went with 16 because that's what's listed in package.json:

"engines": {
"npm": ">=8.0.0",
"node": ">=16.0.0"
},

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, but it doesn't prevent using v18. It only sets the minimum version.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. I don't have a preference on which version is used.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's up to @adamziel then, it can be Node 16, too 😄

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd go with Node 18 just because it's an LTS release

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adamziel Sounds good, updated.

@adamziel
Copy link
Collaborator

Thank you!

@adamziel adamziel merged commit db74b80 into WordPress:trunk Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

.nvmrc and .npmrc
3 participants