Rotate PHP runtime after runtime crash #1628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonpayton
added
[Type] Enhancement
bgrgicak
reviewed
Jul 19, 2024
|
Looks like there is a PHP fatal in the failing e2e test. I think this PR should only rotate the runtime when the actual runtime crashes in some way. PHP fatals occur when the runtime is functioning as designed and should not count here. Time to dig into this some more...
|
|
Good news. It looks like there is a |
brandonpayton
force-pushed
the
rotate-php-runtime-after-crash
branch
from
2948e57
to
86d618b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for the change, related issues
We want Playground to be able be more resilient in the face of PHP crashes. This PR rotates the PHP runtime when a PHP runtime error is detected.
Fixes #1453
Testing Instructions (or ideally a Blueprint)