Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing blueprints library dep #1640

Merged
merged 1 commit into from
Jul 22, 2024
Merged

Conversation

brandonpayton
Copy link
Member

@brandonpayton brandonpayton commented Jul 22, 2024

Motivation for the change, related issues

The ajv library was listed as a dev dependency, but it is used by the actual blueprints library.
Without this, consumers of the @wp-playground/blueprints library encounter an error due to missing ajv lib.

npx --yes @wp-playground/cli start                           
node:internal/errors:496
    ErrorCaptureStackTrace(err);
    ^

Error [ERR_MODULE_NOT_FOUND]: Cannot find package 'ajv' imported from /Users/brandon/src/temp/node_modules/@wp-playground/blueprints/index.js
    at new NodeError (node:internal/errors:405:5)
    at packageResolve (node:internal/modules/esm/resolve:916:9)
    at moduleResolve (node:internal/modules/esm/resolve:973:20)
    at defaultResolve (node:internal/modules/esm/resolve:1193:11)
    at ModuleLoader.defaultResolve (node:internal/modules/esm/loader:404:12)
    at ModuleLoader.resolve (node:internal/modules/esm/loader:373:25)
    at ModuleLoader.getModuleJob (node:internal/modules/esm/loader:250:38)
    at ModuleWrap.<anonymous> (node:internal/modules/esm/module_job:76:39)
    at link (node:internal/modules/esm/module_job:75:36) {
  code: 'ERR_MODULE_NOT_FOUND'
}

Related to #1630

Implementation details

This PR switches ajv from a dev dependency to a normal dependency.

Testing Instructions (or ideally a Blueprint)

CI

The ajv library was listed as a dev dependency,
but it is used by the actual blueprints library.
Without this, consumers of the `@wp-playground/blueprints`
library encounter an error due to missing ajv lib.
@brandonpayton brandonpayton self-assigned this Jul 22, 2024
@brandonpayton brandonpayton requested a review from a team as a code owner July 22, 2024 19:32
@brandonpayton brandonpayton merged commit 32f5c89 into trunk Jul 22, 2024
5 checks passed
@brandonpayton brandonpayton deleted the add-missing-blueprint-dep branch July 22, 2024 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant