Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reinstantiate Changelog generation in GitHub CI #1657

Merged
merged 1 commit into from
Jul 31, 2024

Conversation

adamziel
Copy link
Collaborator

Motivation for the change, related issues

The automated Changelog generation stopped working in May.

The root cause? The CI job didn't explicitly pass the version number to npm run changelog. This PR solves that and backfills all the missing changelog entries.

Fixes #1654

Testing instructions

Merge this PR, release new NPM packages, confirm the changelog was updated. Unfortunatly there's no better way to verify it works :(

cc @brandonpayton

As reported in
#1654, the
automated Changelog generation stopped working in May.

The root cause? The CI job didn't explicitly pass the version number to
`npm run changelog`. This PR solves that and backfills all the missing
changelog entries.

 ## Testing instructions

Merge this PR, release new NPM packages, confirm the changelog was
updated. Unfortunatly there's no better way to verify it works :(
@adamziel adamziel added [Type] Bug An existing feature does not function as intended [Type] Repo / Project Management labels Jul 31, 2024
@adamziel adamziel requested a review from a team as a code owner July 31, 2024 12:06
@adamziel adamziel merged commit 0719c7a into trunk Jul 31, 2024
4 checks passed
@adamziel adamziel deleted the fix-changelog-generation branch July 31, 2024 12:12
@adamziel
Copy link
Collaborator Author

Let's give it a try!

@brandonpayton
Copy link
Member

Wonderful!
cdb69a0

Thanks, @adamziel!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug An existing feature does not function as intended [Type] Repo / Project Management
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

CI: Changelog updates are broken
2 participants