Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix builder redirect #1693

Merged
merged 5 commits into from
Aug 19, 2024
Merged

Fix builder redirect #1693

merged 5 commits into from
Aug 19, 2024

Conversation

brandonpayton
Copy link
Member

Motivation for the change, related issues

The /builder to /builder/builder.html redirect isn't working because nginx doesn't give us a chance to do custom redirects when:

  • a directory exists
  • that directory contains no index file

This PR fixes that redirect.

Implementation details

As a workaround, this PR adds a /builder/index.php file so nginx will invoke PHP and give us an opportunity to apply custom redirects.

This PR also fixes a few uses of deprecated string interpolation syntax.

Testing

Tested manually on the web host

@brandonpayton brandonpayton added [Type] Bug An existing feature does not function as intended [Package][@wp-playground] Website labels Aug 19, 2024
@brandonpayton brandonpayton requested a review from adamziel August 19, 2024 22:42
@brandonpayton brandonpayton self-assigned this Aug 19, 2024
@brandonpayton brandonpayton merged commit 6e63ee0 into trunk Aug 19, 2024
5 checks passed
@brandonpayton brandonpayton deleted the fix-builder-redirect branch August 19, 2024 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package][@wp-playground] Website [Type] Bug An existing feature does not function as intended
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant