-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing functions required to succesfully connect with MySQL DB #1752
base: trunk
Are you sure you want to change the base?
Add missing functions required to succesfully connect with MySQL DB #1752
Conversation
@brandonpayton Do you have a chance to look at this? |
The Dockerfile changes look great and there aren't any other changes required besides rebasing and building. See #1716 which did the same thing for another set of C functions. |
Also, does Electron support JSPI? I was thinking about shipping a set of JSPI binaries for runtimes that support it, it would solve this entire class of Asyncify problems. |
I haven't specific documentation but I think it currently doesn't. However, Electron uses Chromium so if there's a way to enable that feature maybe we could give it a try. |
@adamziel Ah, interesting. Playground is actually running via Node.js (version |
@jeroenpf once this is rebased and the php-wasm binaries are rebuilt, this should be good to go. You may already be familiar with building php-wasm, but just in case, you can do so with the following commands:
|
@fluiddot It looks like support for Node 22 will be added somewhere around November if we go by this chart. |
Great! In that case, we could explore JSPI in a couple of months. I looked for a a potential alpha/beta build in Electron but looks like there's none with Node 22 yet. |
7e6de42
to
3a16b4f
Compare
@adamziel - I've compiled new wasm binaries so we should be good to go :-) |
Motivation for the change, related issues
When trying to connect to a MySQL database (in my case version 8.4.0) several errors regarding unreachable code were triggered, making the site unusable.
I've added the required functions one by one until there were no more errors and I was able to successfully run a site with MySQL.
The errors seem to be related to how MySQL handles authentication specifically.
Implementation details
I did not yet run a full build as I am not sure if there are any additional steps needed to do that. I would appreciate some help with this.
Testing Instructions (or ideally a Blueprint)
127.0.0.1
and provide valid db credentials.