Prefer pretty permalinks like WP install does #1832
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for the change, related issues
The WordPress installation process defaults to pretty permalinks if it can enable them and get a valid response from a loopback request. Unfortunately, at the time we run the WP installation process in Playground, the PHP request handler has not yet been put into place to handle those requests.
In addition, even if the request handler was in place in time, @adamziel mentioned:
As a workaround, we can manually set the
permalink_structure
as part of WordPress installation withinbootWordPress()
.Closes #1644
Implementation details
Manually sets the
permalink_structure
as part of WordPress installation withinbootWordPress()
.Testing Instructions (or ideally a Blueprint)
Manual testing after creating nightly WP build which was pre-installed using this logic using Playground CLI. Loading the nightly build locally shows permalinks enabled.