[Blueprints] Allow multisites to load wp-admin pages with the landingPage attribute #1913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgrgicak
added
[Type] Bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows multisite Blueprints to load
/wp-admin/URLs using thelandingPageattribute.Before this PR multisites were configured with an incorrect base path that broke WordPress rewrites.
WordPress couldn't resolve
/SITE-SLUG/wp-login.phpas/wp-login.php, instead it returned the WordPress 404 page.When a Blueprint attempts to load
/wp-admin/using thelandingPageattribute, it first needs to open/wp-login.phpto log in the user. But, because WordPress couldn't access/wp-login.php, logins were failing, and as a result/wp-admin/pages couldn't be loaded.The fix was to remove a custom
baseURL and let thewp core multisite-convertCLI command create automatically.This PR also adds a test to cover this scenario, so we can make sure it doesn't happen again.
Fixes #1907
Testing Instructions (or ideally a Blueprint)