[CORS Proxy] Rate-limits IPv6 requests based on /64 subnets, not specific addresses #1923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ses. This prevents a person with an entire /64 subnet from exhausting the storage or getting more than their fair share of the tokens. ## Implementation Converts a string-based IP address into a binary string, then zeros the first 64 bits in that string and re-encodes it as a human-readable IP string. ## Testing instructions Run unit tests ```php php ./packages/playground/website-deployment/tests.php ``` cc @brandonpayton for reviews
adamziel
changed the title
adamziel
changed the title
brandonpayton
approved these changes
Oct 23, 2024
There was a problem hiding this comment.
I made a few very small changes. The code looks good to me. I tested this locally with the IPv6 loopback address but not with another IPv6 block. The database entry in the rate-limiting table looked fine.
This should be good enough for now. Please feel free to merge and deploy this. I'm waiting because it is late here, and I don't want to deploy something without being around to revert if needed.
|
Thank you, @adamziel! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rate-limits the CORS proxy requests based on the first 64 bits of an IPv6 address, not all 128 bits. This prevents a person with an entire /64 subnet from exhausting the storage or getting more than their fair share of the tokens. This only applies to IPv6. For IPv4 addresses, all 64 bits are still considered.
Implementation
Converts a string-based IP address into a binary string, then zeros the first 64 bits in that string and re-encodes it as a human-readable IP string.
Testing instructions
cc @brandonpayton for reviews