[Data Liberation] Add XML API, Stream API, WXR URL Rewriter API #1952
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Base automatically changed from
data-liberation-bring-in-php-parsers
to
trunk
October 28, 2024 23:14
bgrgicak
reviewed
Oct 29, 2024
packages/playground/data-liberation/src/stream-api/WP_File_Byte_Stream.php
Show resolved
Hide resolved
| * // <wp:content id="test-4" class=outline title="data:text/plain;base64=asdk3nk1j3fo8"> | ||
| * // ^ parsing will continue from this point. | ||
| * $this->attributes = array( | ||
| * 'id' => new WP_HTML_Attribute_Token( 'id', 9, 6, 5, 11, false ) |
Member
There was a problem hiding this comment.
It's interesting to find WP_HTML_Attribute_Token used in the XML tag processor, but I guess the concepts are the same or nearly the same structurally.
Collaborator
Author
There was a problem hiding this comment.
Yup! But we could also create XML-specific flavors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A part of #1894. Follows up on #1893.
This PR brings in a few more PHP APIs that were initially explored outside of Playground so that they can be incubated in Playground. See the linked descriptions for more details about each API:
Testing instructions