Networking: Preserve the content-type header when fetch()-ing #2028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows the use of arbitrary Content-type header when sending POST requests from WordPress. Playground fetch() network transport for `wp_safe_remote_*` calls enforced the `Content-Type` header of `application/x-www-form-urlencoding` when POST-ing. This PR turns that value into a fallback that's only used if not explicit value is provided. Closes #1428 ## Testing instructions * CI unit tests * Try the Blueprint URL below and confirm in devtools the content-type header used was `text/plain` ``` http://localhost:5400/website-server/#{%22features%22:{%22networking%22:true},%22steps%22:[{%22step%22:%22writeFile%22,%22path%22:%22/wordpress/wp-content/mu-plugins/0-fetch-test.php%22,%22data%22:%22%3C?php%20add_action('init',%20function()%20{%20wp_safe_remote_post('https://api.w.org',array('headers'=%3E['Content-Type'=%3E'text/plain']));%20});%20%22}]} ```
adamziel
added
[Type] Bug
packages/playground/remote/src/lib/setup-fetch-network-transport.ts
Outdated
Show resolved
Hide resolved
brandonpayton
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows the use of arbitrary Content-type header when sending POST requests from WordPress.
Playground fetch() network transport for
wp_safe_remote_*calls enforced theContent-Typeheader ofapplication/x-www-form-urlencodingwhen POST-ing. This PR turns that value into a fallback that's only used if not explicit value is provided.Closes #1428
Testing instructions
text/plain