[Web] Re-enable wp-cron #2039
Merged
[Web] Re-enable wp-cron #2039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I disabled wp-cron a long time ago at a network bridge level with the following comment: > Disable wp-cron requests that are extremely slow in node.js runtime environment. > @todo: Make wp-cron requests faster. Playground changed a lot since then and these requests no longer seem slow in my testing. This PR, thus, reinstantes wp-cron. Related to #1749 ## Testing instructions 1. Install wp-crontrol plugin and confirm on its settings page the schedules are running as expected. Confirm there are requests to wp-cron.php in devtools and that they're not slow. 2. Try it in the web version of Playground (`npm run dev`) 3. Try it in the CLI version of Playgroynd (`bun packages/playground/cli/src/cli.ts server`)
adamziel
commented
Nov 29, 2024
| @@ -84,7 +84,7 @@ export async function handleRequest(data: RequestData, fetchFn = fetch) { | |||
| response = await fetchFn(fetchUrl, { | |||
| method: fetchMethod, | |||
| headers: fetchHeaders, | |||
| body: data.data, | |||
| body: fetchMethod === 'GET' ? undefined : data.data, | |||
There was a problem hiding this comment.
This is a tangential bugfix – I noticed some requests failed with "GET requests cannot have body" when data.data was an empty string.
There was a problem hiding this comment.
This is a tangential bugfix – I noticed some requests failed with "GET requests cannot have body" when data.data was an empty string.
Nice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I disabled wp-cron a long time ago at a network bridge level with the following comment:
That code path wasn't running in Node.js for months now. Also, Playground changed a lot since then and these requests no longer seem slow in my testing. This PR, thus, reinstantes wp-cron.
Related to #1749
Testing instructions
npm run dev)bun packages/playground/cli/src/cli.ts server) – although that one didn't even use the Wp_Http_Fetch_Base transport so nothing should change