Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Website] Switch the CORS Proxy URL to wordpress-playground-cors-proxy.net #2074

Merged

Conversation

adamziel
Copy link
Collaborator

Updates playground.wordpress.net to use the new CORS Proxy URL. This makes sure the requests are not routed through
https://playground.wordpress.net/cors-proxy.php anymore.

As a next step, we should restrict the access from playground.wordpress.net

Testing instructions

None, this is a production-only change. Merge, deploy, confirm it worked.

cc @brandonpayton

…y.net

Updates playground.wordpress.net to use the new CORS Proxy URL. This
makes sure the requests are not routed through
https://playground.wordpress.net/cors-proxy.php anymore.

As a next step, we should restrict the access from
playground.wordpress.net

 ## Testing instructions

None, this is a production-only change. Merge, deploy, confirm it
worked.
@brandonpayton
Copy link
Member

Thank you. ☺️ I was just thinking we'd need to do this.

Copy link
Member

@brandonpayton brandonpayton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do this.

@brandonpayton brandonpayton merged commit 5f7ad69 into trunk Dec 12, 2024
10 checks passed
@brandonpayton brandonpayton deleted the use-wordpres-playground-cors-proxy-dot-net-in-prod branch December 12, 2024 03:08
@brandonpayton
Copy link
Member

I used the test URL from PR #1926:

https://playground.wordpress.net/?php=8.0&wp=6.6&networking=yes&language=&multisite=no&random=f1qv1twpssr#%7B%22landingPage%22:%22/network-test.php%22,%22preferredVersions%22:%7B%22php%22:%228.0%22,%22wp%22:%22latest%22%7D,%22phpExtensionBundles%22:%5B%22kitchen-sink%22%5D,%22steps%22:%5B%7B%22step%22:%22writeFile%22,%22path%22:%22/wordpress/network-test.php%22,%22data%22:%22%3C?php%20echo%20'Hello-dolly.zip%20downloaded%20from%20https://downloads.wordpress.org/plugin/hello-dolly.1.7.3.zip%20has%20this%20many%20bytes:%20';%20var_dump(strlen(file_get_contents('https://downloads.wordpress.org/plugin/hello-dolly.1.7.3.zip')));%22%7D%5D%7D

And the result was:

Hello-dolly.zip downloaded from https://downloads.wordpress.org/plugin/hello-dolly.1.7.3.zip has this many bytes: int(1887)

And the dev tools Networking tab shows a request to https://wordpress-playground-cors-proxy.net/?https://downloads.wordpress.org/plugin/hello-dolly.1.7.3.zip.

Looks like we're in the clear, @adamziel!

@adamziel
Copy link
Collaborator Author

Lovely!

@bph bph changed the title [Webiste] Switch the CORS Proxy URL to wordpress-playground-cors-proxy.net [Website] Switch the CORS Proxy URL to wordpress-playground-cors-proxy.net Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants