[XDebug Bridge] List additional ASYNCIFY_ONLY functions to prevent unreachable crashes when using Devtools
#2454
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for the change, related issues
I listed the two crashes I encountered while using Devtools in the comments.
I am currently recompiling
php-wasm-node:asyncify.Implementation details
Added the following functions in
ASYNCIFY_ONLY_PREFIXED:Testing Instructions
Based on the instructions from #2442
One test is to step into the running files 68 times until breaking on
define( 'WP_DEBUG', false );. The next step would crash previously. Not anymore.The second test is to quit the Devtools tab while it is running. It crashed previously. Not anymore.