Skip to content

Conversation

@mho22
Copy link
Collaborator

@mho22 mho22 commented Sep 8, 2025

Motivation for the change, related issues

Fixes #2602 by externalizing crypto in vite.config.ts files for the Xdebug-bridge and PHP.wasm CLI.

Implementation details

  • Use createHash instead of crypto.createHash [ keeping consistency ]
  • Externalize crypto in Vite's build rollupOptions.

Testing Instructions

First build packages in wordpress-playground

npm run local-package-repository

The install @wp-playground/cli them in wordpress-importer :

"@wp-playground/cli": "http://127.0.0.1:9724/*/v2.0.16/@wp-playground-cli-2.0.16.tar.gz",

Then run Playground CLI

node_modules/.bin/wp-playground-cli server --mount=./src:/wordpress/wp-content/plugins/wordpress-importer --blueprint=e2e/playground.blueprint.json --blueprint-may-read-adjacent-files --port 29400 --xdebug --experimental-devtools

@mho22 mho22 changed the title Fix create hash error in xdebug bridge [Xdebug Bridge] Fix create hash error in xdebug bridge Sep 8, 2025
@mho22 mho22 added [Type] Bug An existing feature does not function as intended XDebug labels Sep 8, 2025
@mho22 mho22 marked this pull request as ready for review September 8, 2025 13:13
@adamziel adamziel merged commit 2bdc036 into trunk Sep 8, 2025
26 checks passed
@adamziel adamziel deleted the fix-create-hash-error-in-xdebug-bridge branch September 8, 2025 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Type] Bug An existing feature does not function as intended XDebug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants