Add /wp-content/fonts/ directory to file paths
#633
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmsnell
approved these changes
Sep 11, 2023
dmsnell
pushed a commit
to ironprogrammer/wordpress-playground
that referenced
this pull request
Sep 11, 2023
The Playground resolves URLs based on their path to determine whether to load the resource at the URL or reroute it to its in-memory storage, such as for themes and plugin content. In WordPress 6.4, user-uploaded fonts will be stored in a new top-level uploads directory and the Playground will need to support this. Otherwise, the Font paths won't resolve properly and the Playground will return 404 errors for them.
dmsnell
force-pushed
the
add/fonts-directory-support
branch
from
5778380
to
b58e396
Compare
ironprogrammer
added a commit
to ironprogrammer/wordpress-playground
that referenced
this pull request
Sep 11, 2023
Per feedback on WordPress#633 (review)
ironprogrammer
force-pushed
the
add/fonts-directory-support
branch
from
c338b60
to
b58e396
Compare
dmsnell
added a commit
that referenced
this pull request
Sep 11, 2023
This patch introduces a small change, where previously the detection for user-uploaded content paths ran multiple checks against the path for possible directories. Now, a single `RegExp` pattern checks in a single pass if the path refers to one of the intended directories. Performance impact should be negligible, but why do five times what can mostly be done once. cc: @ironprogrammer whose work in #633 prompted this change.
adamziel
temporarily deployed
to
wordpress-assets
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR doing?
Adds support for the Font Library's font storage location,
/wp-content/fonts/as of WordPress/gutenberg#54122.What problem is it solving?
Fonts uploaded into a Playgrounds instance do not have their paths resolved properly, resulting in a 404 for user-uploaded font files.
How is the problem addressed?
Adds
/wp-content/fonts/to the allowed file paths, so that user-uploaded font paths are rewritten for browser in-memory scope.Testing Instructions
Run/compare the following Playgrounds instances, which include Gutenberg PR #53884:
.woff2or.ttffile). The font should activate automatically.Note Regarding Initial Font Display in Editor
In Step 4, the new font may not display correctly on headings. This is due to an issue that will be addressed in WordPress/gutenberg#54313. Until this is merged, the editor will need to be reloaded in order to account for the newly added font file.