Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow-modals on sandboxed iframe #679

Merged
merged 1 commit into from
Oct 12, 2023

Conversation

ajitbohra
Copy link
Member

What is this PR doing?

set allow-modal on sandboxed iframe

What problem is it solving?

Allow the website on the playground to show alerts

The team at @lubusIN is testing a set of plugins in the playground and while testing https://wordpress.org/plugins/wp-content-copy-protection/ we noticed that alerts from the plugin are not working. The plugin uses JS to show alerts on the user's right-click.

related #674

@adamziel adamziel merged commit 4c7672d into WordPress:trunk Oct 12, 2023
@adamziel
Copy link
Collaborator

Thank you so much @ajitbohra!

@adamziel adamziel added [Type] Bug An existing feature does not function as intended [Aspect] Browser labels Oct 12, 2023
@adamziel adamziel mentioned this pull request Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Aspect] Browser [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants