Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Blueprint Builder #773
Blueprint Builder #773
Changes from 33 commits
296c863
11b49cd
105691c
9314328
c9dd9ac
2c460bc
9cd7632
afcca2a
120dda7
cce151e
6f262fa
ac47ba9
b62ea14
76db23d
ee9e271
daadd83
ce65295
a033341
d77cbc3
f803380
adb48ec
6968472
08d8255
4696e11
e62e799
ee2b93b
153b734
7c5bf01
8da27b2
dcca302
55763da
867adbf
498bf09
861a628
9d6a08d
6417035
90c0e44
af4b5a2
5ab1e8b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this change required by the Blueprints builder or can it be safely removed from this PR? Polyfilling the File class seems like a distinct issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@adamziel I originally figured we could roll that update into this one, but you're right, we need to keep it separate. I've got another branch for that now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comment for posterity – let's remove this part of the HTML.