Plugin Directory: Plugin Check: Allow plugin check to block plugin su…

…bmissions.

This will output a message of `Results of Automated Plugin Scanning: Fail` along with the failures and not store the upload.

If an upload is successful, but warnings were generated, they will be appended to the success message for fixing.

See #7778.


git-svn-id: https://meta.svn.wordpress.org/sites/trunk@14089 74240141-8908-4e6f-9713-ba540dce6ec7

wordpress.org/public_html/wp-content/plugins/plugin-directory/shortcodes/class-upload-handler.php

@@ -770,7 +770,7 @@ public function check_plugin() {
 		$html .= __( 'Note: While the automated plugin scan is based on the Plugin Review Guidelines, it is not a complete review. A successful result from the scan does not guarantee that the plugin will be approved, only that it is sufficient to be reviewed. All submitted plugins are checked manually to ensure they meet security and guideline standards before approval.', 'wporg-plugins' );
 
 		// If the upload is blocked; log it to slack.
-		if ( ! $verdict || true ) { // TODO: Temporarily logging all to slack, as it's not output to the submitter.
+		if ( ! $verdict ) {
 			// Slack dm the logs.
 			$zip_name = reset( $_FILES )['name'];
 			$failpass = $verdict ? ':white_check_mark: passed' : ':x: failed';
@@ -818,13 +818,6 @@ public function check_plugin() {
 			notify_slack( PLUGIN_CHECK_LOGS_SLACK_CHANNEL, $text, wp_get_current_user(), true );
 		}
 
-		// TODO: Payload to always pass, and not show anything to the submitter, temporary.
-		return [
-			'verdict' => true,
-			'results' => $results,
-			'html'    => '',
-		];
-
 		// Return the results.
 		return [
 			'verdict' => $verdict,