Update header layout #271
Merged
Update header layout #271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamwoodnz
force-pushed
the
update/268-header
branch
from
e45ed9d to
23b3653
Compare
adamwoodnz
changed the base branch from
trunk
to
fix/243-code-reference-layout
adamwoodnz
force-pushed
the
update/268-header
branch
from
23b3653 to
86bb183
Compare
adamwoodnz
force-pushed
the
update/268-header
branch
3 times, most recently
from
aaf56db to
dc5941c
Compare
adamwoodnz
force-pushed
the
update/268-header
branch
from
2243856 to
52dd5e7
Compare
|
I tested this (without WordPress/wporg-parent-2021#103). LGTM A couple non-blocking thoughts:
|
Yeah this should use the local nav bar containing a site-title and navigation block like Main and Documentation. I'll update once those changes are shipped. |
adamwoodnz
force-pushed
the
update/268-header
branch
2 times, most recently
from
d268d9f to
3d777fe
Compare
Depend on parent theme instead.
adamwoodnz
force-pushed
the
update/268-header
branch
from
4ba6dad to
1c7f150
Compare
Makes development of the content easier
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #268
Moves the breadcrumbs below the local nav bar, updates text and aligns the ToC.
Depends on WordPress/wporg-mu-plugins#439 and
WordPress/wporg-parent-2021#103Destination for Code Reference link TBC by design.Screenshots
Home
Code Reference
Coding Standards
Testing