Fix compatibility issues with shortcodes in blocks and Gutenberg 18.1+ #517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After WordPress/gutenberg#60349, shortcodes passed via block attributes don't work. Shortcodes in block markup in patterns do work, so stop using custom blocks and move the logic to the template level instead.
adamwoodnz
commented
May 8, 2024
Comment on lines
-72
to
-76
| // The block editor handbook doesn't have a changelog. | ||
| // We only know it's the changelog because of the linkURL attribute. | ||
| if ( 'blocks-handbook' === $post_type && '[article_changelog_link]' === $block['attrs']['linkURL'] ) { | ||
| return ''; | ||
| } |
There was a problem hiding this comment.
This logic replaced by the switch here
adamwoodnz
commented
May 8, 2024
Comment on lines
-65
to
-70
| $local_handbooks = array( 'apis-handbook', 'plugin-handbook', 'theme-handbook' ); | ||
| $post_type = get_post_type(); | ||
|
|
||
| if ( in_array( $post_type, $local_handbooks ) ) { | ||
| return ''; | ||
| } |
There was a problem hiding this comment.
This logic replaced by reverting the removal of the single-handbook-github.html template
ryelle
approved these changes
May 8, 2024
There was a problem hiding this comment.
Links & dates all work, checked a few different handbook pages. I left two comments, but this shouldn't need a re-review to merge 👍🏻
The result is a fair bit of markup duplication but the reduction of custom block usage and hidden complexity is probably positive.
Yeah, it's too bad about the duplication, but this is probably closer to how core expects themes to behave, so hopefully less likely to break 🤞🏻
source/wp-content/themes/wporg-developer-2023/inc/shortcodes.php
Outdated
Show resolved
Hide resolved
source/wp-content/themes/wporg-developer-2023/patterns/article-meta-block-editor.php
Outdated
Show resolved
Hide resolved
adamwoodnz
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #513
After WordPress/gutenberg#60349, shortcodes passed via block attributes don't work.
Shortcodes in block markup in patterns do work, so this PR removes the custom block usage and puts the shortcodes directly in the pattern markup. The main reason for using these custom blocks was conditional rendering, which has been moved to the template level.
The result is a fair bit of markup duplication but the reduction of custom block usage and hidden complexity is probably positive.
Testing