Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Homepage Search Placeholder Text #27

Closed
bengreeley opened this issue Dec 20, 2022 · 2 comments
Closed

Homepage Search Placeholder Text #27

bengreeley opened this issue Dec 20, 2022 · 2 comments
Labels
[Component] Theme Templates, patterns, CSS

Comments

@bengreeley
Copy link

It appears there should be placeholder text in the search field on the homepage (assuming this is the latest version).

Screenshot 2022-12-20 at 9 56 07 AM

@ryelle
Copy link
Collaborator

ryelle commented Jan 2, 2023

The team got feedback that adding placeholders makes the search field overly verbose for screen readers. There's an issue in the parent theme to revisit this design pattern: WordPress/wporg-parent-2021#62 (comment)

I can add the placeholder back for now while the designers figure out a visible label.

@ryelle ryelle added [Component] Theme Templates, patterns, CSS Accessibility Issues related to keyboard navigation, screen readers, etc labels Jan 2, 2023
@ryelle ryelle added this to the Initial design launch milestone Jan 2, 2023
@ryelle ryelle removed the Accessibility Issues related to keyboard navigation, screen readers, etc label Jan 2, 2023
@ryelle
Copy link
Collaborator

ryelle commented Jan 4, 2023

This is just page content, so I've added the placeholder into the search on https://wordpress.org/documentation-test/.

@ryelle ryelle closed this as completed Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Component] Theme Templates, patterns, CSS
Projects
None yet
Development

No branches or pull requests

2 participants