Searchbar: Redundant voiceover due to label and placeholder.

[StevenDufresne]

See: WordPress/wporg-showcase-2022#25 for more information.

[ryelle]

Adding more context from slack (thread):

"Search lesson plans" has a label of "Search for". This results in reading that's "Search landmark. Search for: Search lesson plans". It's very verbose. Would be better if there was just a visible label with "Search lesson plans" and no placeholder.

The issue is that we have a placeholder, basically. The label exists, but is hidden. All the new search fields have been styled to use this pattern, which will create the verbose output (a hidden label and a placeholder). Additionally, while I don't think this technically fails WCAG, the placeholder works as the visual label and it disappears as soon as you start typing.

Learn fixed this by making the label visual & removing the placeholder.