Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Language bar: move below top header. #62

Closed
ryelle opened this issue May 5, 2023 · 3 comments
Closed

Language bar: move below top header. #62

ryelle opened this issue May 5, 2023 · 3 comments
Labels
[Component] Theme Templates, patterns, CSS [Status] Needs Design Feedback [Status] On Hold Work is paused temporarily

Comments

@ryelle
Copy link
Collaborator

ryelle commented May 5, 2023

Extracting from WordPress/wporg-main-2022#253:

The language banner is in an unconventional position, worth trying at the top below top bar.

This banner is used on the homepage of Documentation, to suggest the localized support forums.

Current Proposed
current proposed

@jasmussen Is that the location you expected for this page? If so, the two top-navs are sticky, so what should happen when the page is scrolled?

@ryelle ryelle moved this to 🛑 Pending discussion in WordPress.org May 5, 2023
@jasmussen
Copy link

Thanks for trying that. Yep, that does break up the blue. CC: @pablohoneyhoney @fcoveram 🤔

@fcoveram
Copy link

fcoveram commented May 8, 2023

I would keep it below the header. The break up does not add more value conveying its purpose.

The language banner is in an unconventional position

To this point, I'm drawn to revamp the banner style and make it look less like a banner and more like a section. I can work on an idea these days.

@ryelle ryelle moved this from 🛑 Pending discussion to ⚠ On Hold/Blocked in WordPress.org May 10, 2023
@ryelle ryelle added the [Status] On Hold Work is paused temporarily label May 10, 2023
@ryelle
Copy link
Collaborator Author

ryelle commented Aug 7, 2024

Closing this issue, it references an older iteration of the design, and the locale banner is used in this position across the site.

See WordPress/wporg-mu-plugins#629 for a current issue on locale banner positioning.

@ryelle ryelle closed this as not planned Won't fix, can't repro, duplicate, stale Aug 7, 2024
@github-project-automation github-project-automation bot moved this from ⚠ On Hold/Blocked to ✅ Done in WordPress.org Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Component] Theme Templates, patterns, CSS [Status] Needs Design Feedback [Status] On Hold Work is paused temporarily
Projects
Archived in project
Development

No branches or pull requests

3 participants