-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Language bar causes layout shift #629
Comments
It should be available on the homepage and on single plugins/themes, since those also include specific details about the theme/plugin. It could probably be removed from archive pages, but if we fix the layout shift I don't see a drawback to having it. It's also available on the main homepage, Documentation homepage, Forums homepage, Learn (homepage and all interior pages). So any solution will need to work for all of these. It's not on Patterns, but it should be (WordPress/pattern-directory#705). It used to be on /download, but was removed— maybe with the redesign rollout.
No, it requires information from the client browser for the language hints, so it can't be rendered server-side.
Possibly, though it would need some more work— on desktop it works, but as the spacing value shrinks on smaller screens, it collides with the content. On single themes/plugins, with the larger banner, it takes up almost all that space.
|
From my angle it's not just the layout shift, it's the prominence of the callout, which is designed to be visually noticable and therefore implied to be important. And while it's important to solicit translations (therefore homepage and single plugin pages being sensible)—it's really not a task that should befall 80% of visitors. So for me it's mainly about reducing the footprint and prominence. |
This is likely an issue for language bars across the site, so feel free to move the issue if need be. It's also not the highest priority, but worth refining. If you click between the tabs in the theme directory, the language-bar causes a layout shift:
This happens as initially the bar is not present, and then it loads after a bit. What are some options to improve this?
The text was updated successfully, but these errors were encountered: