-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Headers: Use native sticky local navigation bar & site breadcrumbs #71
Conversation
@fcoveram I believe the breadcrumbs should not be sticky, correct? Sorry to keep repeating this question! Just not sure if we're going with that for the whole network. I think this is the outlier now, all others do not have sticky breadcrumbs :) |
649591e
to
faff5ff
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just the one existing question on the sticky breadcrumbs.
No worries @adamwoodnz for asking me again 😃 And yes, no sticky breadcrumb. |
This will be necessary if WordPress/wporg-mu-plugins#466 merges, because the sticky behavior will change. This should make it easier to implement sticky bars on child themes, but does require updating the current sites that are using the older
is-sticky
class.Other changes I made:
local-navigation-bar
, this is set correctly by default nowlocal-navigation-bar
to the global header, this looks better when the page scrollslocal-navigation-bar
was moved out of the group, I moved thestyle
attribute tolocal-navigation-bar
directlyScreenshots
This fixes an issue with the homepage scroll, and makes the breadcrumbs sticky.
How to test the changes in this Pull Request: