Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pattern: Download button #8

Closed
ryelle opened this issue Jul 20, 2022 · 3 comments
Closed

Pattern: Download button #8

ryelle opened this issue Jul 20, 2022 · 3 comments
Assignees
Labels
[Component] Blocks Custom blocks or block variations

Comments

@ryelle
Copy link
Contributor

ryelle commented Jul 20, 2022

Do we need a custom block for the download button, or can it be a regular button block?

Is it a static link (always https://wordpress.org/latest.zip) or do we need to add the version/timestamp/SHA/etc to it? In wporg-main, the URL is dynamic, but that's because it can be updated to point to the locale-specific build.

Current mockup:

Screen Shot 2022-07-20 at 4 38 44 PM

@ryelle ryelle added [Component] Blocks Custom blocks or block variations [Type] Question Needs input from others before actionable labels Jul 20, 2022
@ryelle ryelle moved this to 🛑 On hold in WordPress.org Jul 20, 2022
@ryelle ryelle added [Status] Needs Design Design is needed before implementation can start and removed [Type] Question Needs input from others before actionable labels Jul 25, 2022
@dd32
Copy link
Member

dd32 commented Jul 28, 2022

It seems like the immediate needs here can be solved by a shortcode, rather than a custom block. See #10 + #27.

A custom pre-defined button block with the shortcodes (and later tokens) wouldn't be out of the question though to simplify the editing experience.

@ryelle
Copy link
Contributor Author

ryelle commented Jul 28, 2022

I think we could create a pattern that uses the shortcodes, rather than a custom block, so editors can just drop the pattern in place.

@ryelle ryelle removed the [Status] Needs Design Design is needed before implementation can start label Aug 1, 2022
@ryelle ryelle self-assigned this Aug 1, 2022
@ryelle ryelle moved this from 🛑 Pending discussion to 📋 To do in WordPress.org Aug 1, 2022
@ryelle ryelle changed the title Block: Download button Pattern: Download button Aug 1, 2022
@ryelle
Copy link
Contributor Author

ryelle commented Sep 15, 2022

Closing in favor of the eventual download modal block #52

@ryelle ryelle closed this as completed Sep 15, 2022
@ryelle ryelle removed this from WordPress.org Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Component] Blocks Custom blocks or block variations
Projects
None yet
Development

No branches or pull requests

2 participants