-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create a shortcode for WP_MARKET_SHARE
#10
Comments
There are also a few other places in the current These probably aren't as important - the copy might change, and even if not, these can probably stay static for a while. The meetup count was last updated 3 years ago, the only time since it was added. |
Could we do this with a few super-simple server side blocks? That basically just run your code snippet, or similar to it. |
IMHO; for the initial release I would just use an inline shortcode. It looks like "tokens" will be shortcodes-v2 which would likely be the proper solution in future. WordPress/gutenberg#42015 |
I agree. If we want to make it easier for editors we could add a toolbar button/dropdown like #16 to insert these, but spending too much time here doesn't make much sense if a core solution is on the way. |
WP_MARKET_SHARE
?WP_MARKET_SHARE
Renamed & moved this to "to do" since it sounds like we have a path forward. |
This is a single defined constant that provides the current WP market share (ex, 43%). In
wporg-main
, this is used to build strings, so that they don't need to be re-translated every time the percentage changes. It also keeps the value defined in one place, so we don't end up with 40% in one place, and 43% in another.How should we handle this for content entered in the block editor?
The text was updated successfully, but these errors were encountered: