Blocks: Create a stub Download Modal "block" #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryelle
commented
Aug 25, 2022
| import DownloadModal from './DownloadModal'; | ||
| import DownloadModal from './download-modal'; |
There was a problem hiding this comment.
Renamed this file to follow the WP coding standards: files should be lowercase, words separated with hypens.
adamwoodnz
approved these changes
Aug 25, 2022
Works for me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the download modal code into a subfolder in
src, so that we can create additional blocks without needing a customwebpack.config.js. By default,wp-scriptswill look in the src folder for anyblock.jsonfiles, and pull out the scripts referenced. We can use that behavior without creating a proper block by adding ablock.jsonfile with just the script. This "block" is not registered anywhere, and the JS is still enqueued the same way it was before.Other blocks can be added as sibling folders to
download, and they'll automatically be built too.See #52 — eventually this will be a real block, so this won't be a workaround forever.
Screenshots
No visual changes.
How to test the changes in this Pull Request:
yarn workspace wporg-main-2022-theme buildbuild/download