Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Global header menus broken on Safari #632

Closed
adamwoodnz opened this issue Jun 23, 2024 · 9 comments
Closed

Global header menus broken on Safari #632

adamwoodnz opened this issue Jun 23, 2024 · 9 comments
Assignees
@adamwoodnz
Labels
[Block] Header & Footer [Type] Bug Something isn't working

Comments

@adamwoodnz
Copy link
Contributor

Reported in Slack

Since the latest update to wordpress.org, the menus Extend, Learn, Community, and About do not work on Safari on my MacBook Pro, Safari Version 17.5 (19618.2.12.11.6) & MacOS 14.5 (23F79). They work on Safari on my iPhone and iPad. No problems with Chrome and Firefox. Clicking on the menus doesn’t do anything. I need to type in https://wordpress.org/plugins/ for example to get to the plugins as clicking on Extend doesn’t do anything. The behavior is like those menu elements don’t get triggered by mouse clicks.
@adamwoodnz
Copy link
Contributor Author

adamwoodnz commented Jun 23, 2024 •
edited
Loading

Reproduced locally with Gutenberg 18.6, was not an issue with 18.4.1.

Production is running 18.6

@adamwoodnz
Copy link
Contributor Author

On clicking the submenu I can briefly see aria-expanded become true, before it immediately becomes false again, so the click event is firing, but something is likely wrong with the interactivity API state.

@adamwoodnz
Copy link
Contributor Author

adamwoodnz commented Jun 24, 2024 •
edited
Loading

This change looks closely related

@adamwoodnz
Copy link
Contributor Author

Pinned Gutenberg to 18.5.0 as a temp fix.

@luisherranz
Copy link
Member

I've opened a PR with the fix:

@cbravobernal
Copy link

I've released Gutenberg 18.6.1 with that fix.

@adamwoodnz
Copy link
Contributor Author

18.6.1 has been deployed, looks good. Thanks all!

@adamwoodnz adamwoodnz self-assigned this Jun 25, 2024
@ryelle
Copy link
Contributor

ryelle commented Jul 4, 2024

If the GB update fixed this, can the issue be closed or is there something to follow up on?

@adamwoodnz
Copy link
Contributor Author

Thanks for the reminder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adamwoodnz adamwoodnz

Labels
[Block] Header & Footer [Type] Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ryelle @adamwoodnz @luisherranz @cbravobernal