Navigation block: Fix submenu not opening on macOS Safari

[luisherranz]

What?

This pull request fixes an issue in Safari Desktop (macOS) where submenus do not open upon clicking due to a change in #62160.

Why?

Right now (Gutenberg 18.6), the submenus that have the "Open on Click" option do not open on Safari Desktop.

How?

For now, I have simply reverted the change that causes the submenus to stop opening. I haven't investigated exactly why it happens yet.

It took us a while to figure out how to make the focus logic work properly in Safari since it functions completely differently than in Chrome and Firefox. That logic is also not as clean and straightforward as we would like:

• Focus submenu button when clicked #55198

I think for now we could leave this event handler as asynchronous to fix this bug and take a closer look at the Safari focus logic in a subsequent PR.

Testing Instructions

• Add a menu with a submenu
• Activate the option "Open on click"
• Use Safari macOS
• Test that the submenu opens on click
• Test that the rest of features/accessibility work as usual

[github-actions]

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: luisherranz <luisherranz@git.wordpress.org>
Co-authored-by: westonruter <westonruter@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

[luisherranz]

I think we need to add this fix to WP 6.6 and maybe even release a Gutenberg 18.6.1 version, don't we?

cc: @cbravobernal, @gziolo, @westonruter

[github-actions]

Flaky tests detected in 53d747b.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/9648057681
📝 Reported issues:

• [Flaky Test] create a new page, edit template and toggle page template preview #60102 in /test/e2e/specs/site-editor/pages.spec.js

[westonruter]

Aside: It would be great if the navigation block could start to leverage the Popover API since it is newly available in all browsers which would enable the menus to work even with JavaScript turned off entirely (cf. https://core.trac.wordpress.org/ticket/50182#comment:9)

[ellatrix]

I just cherry-picked this PR to the wp/6.6-rc-1 branch to get it included in the next release: f5ee0dd

[luisherranz]

@cbravobernal just released GB 18.6.1 with this fix:

• https://github.com/WordPress/gutenberg/releases/tag/v18.6.1