Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Profiles header/footer missing styles, footer laid out in sidebar #81

Closed
7 tasks done
Tracked by #44
iandunn opened this issue Jan 12, 2022 · 5 comments
Closed
7 tasks done
Tracked by #44

Profiles header/footer missing styles, footer laid out in sidebar #81

iandunn opened this issue Jan 12, 2022 · 5 comments
Assignees
@iandunn
Labels
[Type] Bug Something isn't working
Milestone
News launch

Comments

@iandunn
Copy link
Member

iandunn commented Jan 12, 2022 •
edited
Loading

Maybe similar issue to #78 but w/ BuddyPress instead of GlotPress

  • pull header/footer from rest api
  • need to call wp_head() and output inside <head>
  • minor differences in spacing
  • footer laid out in sidebar
  • mobile search input margin different
  • mobile menu item spacing different
  • account for admin bar not being present
@iandunn iandunn mentioned this issue Jan 12, 2022
Closed
26 tasks
@iandunn iandunn self-assigned this Jan 12, 2022
@iandunn iandunn added the [Type] Bug Something isn't working label Jan 12, 2022
@iandunn iandunn added this to the News launch milestone Jan 12, 2022
@dd32
Copy link
Member

dd32 commented Jan 13, 2022

https://meta.trac.wordpress.org/changeset/11436 may help here - specifically body.wporg-responsive .wp-block-group.global-footer { clear: both }.

The old footer styles had a clear, which the older themes are expecting.

I didn't realise profiles was affected too, so droping the body.wporg-responsive part from that wp4 style might work.

@iandunn
Copy link
Member Author

iandunn commented Jan 13, 2022

👍🏻 thanks! I'll play around w/ that.

@dd32
Copy link
Member

dd32 commented Jan 14, 2022

droping the body.wporg-responsive part from that wp4 style might work.

Did that for Trac support too. https://meta.trac.wordpress.org/changeset/11441

@iandunn
Copy link
Member Author

iandunn commented Jan 14, 2022

Thanks :)

@iandunn iandunn mentioned this issue Jan 14, 2022
Closed
30 tasks
iandunn added a commit that referenced this issue Jan 19, 2022
@iandunn
Header/Footer: Add global-header-footer/v1/styles route for Profiles.
00afe59 
Profiles can't access the styles directly because it's on the BuddyPress network rather than the w.org one.

See #81
@iandunn iandunn mentioned this issue Jan 19, 2022
Open
12 tasks
@iandunn
Copy link
Member Author

iandunn commented Jan 19, 2022

Fixed by 00afe59 and r18316-dotorg

@iandunn iandunn closed this as completed Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iandunn iandunn

Labels
[Type] Bug Something isn't working
Projects
None yet
Milestone
News launch
Development

No branches or pull requests
2 participants
@iandunn @dd32