Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change footer Twitter icon to X #457

Merged
merged 2 commits into from
Sep 27, 2023

Conversation

ndiego
Copy link
Member

@ndiego ndiego commented Sep 26, 2023

To correspond with X's new branding guidelines, let's switch out the old Twitter logo with X.

The footer links are powered by the Core Social Links block. This block will get the X icon in Gutenberg 16.7, set to be released on 9/27 per WordPress/gutenberg#54092.

This PR should only be merged after 16.7 is deployed across WordPress.org.

Before After (w/ Gutenberg 16.7+)
image image

@ndiego ndiego requested a review from ryelle September 26, 2023 18:05
Copy link
Contributor

@StevenDufresne StevenDufresne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good. Minor comment.

mu-plugins/blocks/global-header-footer/footer.php Outdated Show resolved Hide resolved
Copy link
Contributor

@ryelle ryelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍🏻

@ryelle ryelle merged commit d28da17 into WordPress:trunk Sep 27, 2023
2 checks passed
ryelle added a commit that referenced this pull request Sep 27, 2023
ryelle added a commit that referenced this pull request Sep 27, 2023
@ryelle
Copy link
Contributor

ryelle commented Sep 27, 2023

@ndiego Sorry I had to revert this, can you make another PR? Then it can be merged whenever we can unpin Gutenberg (might need to wait for 16.8 for the forums fix).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants